[TxMt] Crash when double clicking / icon clicking .xcodeproj file

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[TxMt] Crash when double clicking / icon clicking .xcodeproj file

Koen Punt
Hi,

For some reason textmate crashes when I try to open a .xcodeproj from the filebrowser. This however only happens within certain context, because when having only a .xcodeproj in a directory, the crash doesn't happen.

Associated crash reports: 

https://api.textmate.org/crashes/350853
https://api.textmate.org/crashes/350854
https://api.textmate.org/crashes/350855

Any idea what is going on there?

– Koen


Sent from Nylas N1, the extensible, open source mail client.


_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[TxMt] Re: Crash when double clicking / icon clicking .xcodeproj file

Allan Odgaard-4

On 7 Dec 2016, at 21:42, Koen Punt wrote:

Any idea what is going on there?

I can see what code is involved, but the crash is not something we have been able to reproduce (it has been reported a few times before).

I will likely have to rewrite the code because it’s about trying to make the NSOutlineView support lazy-loading of items, which it doesn’t seem designed for, and apparently my current solution has this edge-case where it can go into an infinite loop, but as this is all async/delayed code and majority of it is system code, I don’t have a good grasp of what is really happening.

But I will not touch this code until after a 2.0 release (non beta/release-candidate), as it works for most users (only 25 reports for rc.4 about this, 7 of which are yours) — I foresee changing this code needing a bit of trial and error given the nature of the problem (trying to make a system component do something it is not meant to do).



_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[TxMt] Re: Crash when double clicking / icon clicking .xcodeproj file

Koen Punt
Thanks for the info. Now I'm wondering, is the issue specific to xcodeproj files or can it happen with other files too?

Verstuurd vanaf mijn iPhone

Op 8 dec. 2016 om 07:57 heeft Allan Odgaard <[hidden email]> het volgende geschreven:

On 7 Dec 2016, at 21:42, Koen Punt wrote:

Any idea what is going on there?

I can see what code is involved, but the crash is not something we have been able to reproduce (it has been reported a few times before).

I will likely have to rewrite the code because it’s about trying to make the NSOutlineView support lazy-loading of items, which it doesn’t seem designed for, and apparently my current solution has this edge-case where it can go into an infinite loop, but as this is all async/delayed code and majority of it is system code, I don’t have a good grasp of what is really happening.

But I will not touch this code until after a 2.0 release (non beta/release-candidate), as it works for most users (only 25 reports for rc.4 about this, 7 of which are yours) — I foresee changing this code needing a bit of trial and error given the nature of the problem (trying to make a system component do something it is not meant to do).


_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate


_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[TxMt] Re: Crash when double clicking / icon clicking .xcodeproj file

Allan Odgaard-4

On 8 Dec 2016, at 14:49, Koen Punt wrote:

Thanks for the info. Now I'm wondering, is the issue specific to xcodeproj files or can it happen with other files too?

Everyone who has contacted us about it, has mentioned Xcode project files as the source, though the crash log does not directly point to the Xcode data source being responsible, and I wouldn’t think it is directly responsible, as of such, it shouldn’t be able to cause anything special, as it’s a self-contained data source that does not speak directly with the NSOutlineView, where the crash (stack overflow) happens.

I could remove the Xcode support, this should cause no issues other than taking away functionality. Don’t know if anyone depend on this.



_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[TxMt] Re: Crash when double clicking / icon clicking .xcodeproj file

Allan Odgaard-4
On 8 Dec 2016, at 21:40, Allan Odgaard wrote:

> I could remove the Xcode support, this should cause no issues other
> than taking away functionality. Don’t know if anyone depend on this.

As a (potential) temporary fix, I made the Xcode datasource support
opt-in:
https://github.com/textmate/textmate/commit/2c524907d6a36cd3c0f14e52a9b973ed2ac1822c

_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[TxMt] Re: Crash when double clicking / icon clicking .xcodeproj file

Koen Punt
I found that a plain installation of a react-native project has the crash happening. Maybe you can reproduce it in this test project: https://github.com/koenpunt/TextMateCrash/

Sent from Nylas N1, the extensible, open source mail client.

On Dec 10 2016, at 2:18 pm, Allan Odgaard <[hidden email]> wrote:

On 8 Dec 2016, at 21:40, Allan Odgaard wrote:

> I could remove the Xcode support, this should cause no issues other
> than taking away functionality. Don’t know if anyone depend on this.

As a (potential) temporary fix, I made the Xcode datasource support
opt-in:
https://github.com/textmate/textmate/commit/2c524907d6a36cd3c0f14e52a9b973ed2ac1822c

_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate



_______________________________________________
textmate mailing list
[hidden email]
http://lists.macromates.com/listinfo/textmate
Loading...